Accept NNC with no NC as valid and consider pool monitor and reconciler started #1526
+11
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
changed the title
… started Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
thatmattlong
approved these changes
Aug 12, 2022
Collaborator
thatmattlong
left a comment
thatmattlong
left a comment
There was a problem hiding this comment.
Approving assuming the answer to my question is that it doesn't matter if we don't have a scaler yet and it will get updated later.
| } | ||
| } | ||
|
|
||
| scaler := nnc.Status.Scaler |
Collaborator
There was a problem hiding this comment.
If we don't have NCs we probably don't have a Status at all yet, does this matter? Will the pool monitor start respecting the real scaler when it comes in later?
Collaborator
Author
There was a problem hiding this comment.
Yes, next time we get an NNC we will copy the scaler out again, and I think this zero-value scaler is safe to use
Collaborator
Author
|
bypassing broken aks-e check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Evan Baker rbtr@users.noreply.github.com
Reason for Change: Due to superficial usage of the NC in the IPAM Pool Monitor, it was considered un-started until it received an NNC with an NC. This change fixes that and considers the reconciler and monitor started as soon as an NNC is ready, whether or not the NC is ready also.
Issue Fixed:
Requirements:
Notes: