Skip to content

Conversation

@thatmattlong
Copy link
Collaborator

@thatmattlong thatmattlong commented Aug 11, 2022

Reason for Change:

CNS shouldn't CreateOrUpdateNCInternal a NC that was created for a different Node IP. If the Node IPs don't match, DNC-RC will eventually clean it up, so it is not valid for use.

@thatmattlong thatmattlong requested a review from a team as a code owner August 11, 2022 20:26
@thatmattlong thatmattlong requested review from rbtr and removed request for a team August 11, 2022 20:26
rbtr
rbtr previously approved these changes Aug 16, 2022
Copy link
Collaborator

@rbtr rbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ✅

@rbtr rbtr merged commit 0743278 into Azure:master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants