Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: support zap.Object in zapai
Reason for Change:
currently the zapai evaluates a zapcore.Field into a best-effort string, per the fieldStringer , this bring some troubles to log the zap object. Ex, while logging zap.Object("ex1", &ex1), the result looks like this
"ex1":"&{ex1 2 0 0xc0000ef880}"instead of logging the actual object fields ,so I would like to make zapai support zap.Object by implementing the ObjectEncoder interface, and leverage ObjectMarshaler to help adding object fields into logging context. However the appinsights.TraceTelemetry.BaseTelemetry only take (string: string) pair as custom properties,, that is why I only implement the AddObject and AddString in the interface for now. But I can still implement the rest of methods and convert those non-string and non-object type into a best-effort string.Requirements:
Notes: