feat: extend fieldStringer to support zap ErrorType and BoolType #1532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
force-pushed
the
extend_fieldStringer
branch
from
e3798e7 to
86cd44b
Compare
rbtr
previously approved these changes
Aug 16, 2022
ZetaoZhuang
force-pushed
the
extend_fieldStringer
branch
from
86cd44b to
30be0bd
Compare
ZetaoZhuang
force-pushed
the
extend_fieldStringer
branch
2 times, most recently
from
3587e90 to
371067e
Compare
rbtr
reviewed
Aug 18, 2022
zapai/encoder.go
Outdated
|
|
||
| case zapcore.BoolType: | ||
| return strconv.FormatBool(f.Integer == 1) | ||
|
|
Collaborator
There was a problem hiding this comment.
why do you have all this extra whitespace? 🥲
Contributor
Author
There was a problem hiding this comment.
you mean the empty line right? removed.
ZetaoZhuang
force-pushed
the
extend_fieldStringer
branch
from
371067e to
b85e617
Compare
ZetaoZhuang
force-pushed
the
extend_fieldStringer
branch
from
b85e617 to
917c503
Compare
rbtr
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
extend fieldStringer to support zap ErrorType and BoolType, so zap.Error and zap.Bool fields can be better map to strings while constructing TraceTelemetry
Issue Fixed:
Requirements:
Notes: