-
Notifications
You must be signed in to change notification settings - Fork 260
Pipeline support for Go submodules versioned independently of root repo #1533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e9eb784 to
3d9855b
Compare
camrynl
previously approved these changes
Aug 17, 2022
Contributor
camrynl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
52bd366 to
ccaaa02
Compare
3 tasks
b15e2bb to
8ed179e
Compare
2feea69 to
b0819e7
Compare
b0819e7 to
c4dcb28
Compare
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
c4dcb28 to
273d879
Compare
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
tamilmani1989
previously approved these changes
Aug 31, 2022
273d879 to
5e2307d
Compare
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
5e2307d to
363b3cf
Compare
camrynl
approved these changes
Sep 1, 2022
Contributor
camrynl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to go 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Certain components in this (mono)repo are structured as separate Go modules. Go supports independently versioning nested modules in Git repos by tagging them with their path prefix, eg: a Git tag of
zapai/v0.0.1on this monorepo is understood by Go mod and other tooling to represent the dependencygithub.com/Azure/azure-container-networking/zapai@v0.0.1. Bare tags can coexist with module prefixed tags, and will continue to represent the module located at the root of the repo.This change updates the Makefile and pipelines to support building and publishing nested modules using their prefixed tags, instead of the root repo tag.
Issue Fixed:
Requirements:
Notes: