Skip to content

Conversation

@rbtr
Copy link
Collaborator

@rbtr rbtr commented Aug 17, 2022

Reason for Change:

Certain components in this (mono)repo are structured as separate Go modules. Go supports independently versioning nested modules in Git repos by tagging them with their path prefix, eg: a Git tag of zapai/v0.0.1 on this monorepo is understood by Go mod and other tooling to represent the dependency github.com/Azure/azure-container-networking/zapai@v0.0.1. Bare tags can coexist with module prefixed tags, and will continue to represent the module located at the root of the repo.

This change updates the Makefile and pipelines to support building and publishing nested modules using their prefixed tags, instead of the root repo tag.

Issue Fixed:

Requirements:

Notes:

@rbtr rbtr requested review from camrynl, matmerr and pjohnst5 August 17, 2022 00:33
@rbtr rbtr force-pushed the submodule-versions branch from e9eb784 to 3d9855b Compare August 17, 2022 17:57
camrynl
camrynl previously approved these changes Aug 17, 2022
Copy link
Contributor

@camrynl camrynl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@rbtr rbtr force-pushed the submodule-versions branch 7 times, most recently from 52bd366 to ccaaa02 Compare August 20, 2022 01:22
@rbtr rbtr self-assigned this Aug 24, 2022
@rbtr rbtr force-pushed the submodule-versions branch 5 times, most recently from b15e2bb to 8ed179e Compare August 26, 2022 18:40
@rbtr rbtr requested a review from vakalapa as a code owner August 26, 2022 18:40
@rbtr rbtr force-pushed the submodule-versions branch 6 times, most recently from 2feea69 to b0819e7 Compare August 29, 2022 18:21
@rbtr rbtr added the ci Infra or tooling. label Aug 29, 2022
@rbtr rbtr force-pushed the submodule-versions branch from b0819e7 to c4dcb28 Compare August 30, 2022 15:50
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
rbtr added 2 commits August 30, 2022 23:34
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
@rbtr rbtr force-pushed the submodule-versions branch from c4dcb28 to 273d879 Compare August 30, 2022 23:35
@rbtr rbtr enabled auto-merge (squash) August 31, 2022 17:29
@rbtr
Copy link
Collaborator Author

rbtr commented Aug 31, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

tamilmani1989
tamilmani1989 previously approved these changes Aug 31, 2022
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
@rbtr rbtr force-pushed the submodule-versions branch from 5e2307d to 363b3cf Compare September 1, 2022 02:06
@rbtr rbtr requested a review from camrynl September 1, 2022 17:53
Copy link
Contributor

@camrynl camrynl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go 👍

@rbtr rbtr merged commit 8888338 into Azure:master Sep 1, 2022
@rbtr rbtr deleted the submodule-versions branch September 1, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Infra or tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants