fix: [NPM-LINUX] resiliency for several non-retriable errors #1566
+122
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huntergregory
changed the title
huntergregory
changed the title
huntergregory
changed the title
huntergregory
changed the title
…azure-container-networking into npm-exponential-try-count
huntergregory
changed the title
huntergregory
commented
Nov 2, 2022
| if currentLineIndex == lineNum-1 { | ||
| lineIndex = currentLineIndex | ||
| if currentLineNum == lineNum { | ||
| lineIndex = i |
Contributor
Author
There was a problem hiding this comment.
bug fix here that impacts the 2nd+ retry
Contributor
Author
There was a problem hiding this comment.
before, we may map a line error on line 5 to the original line 5 (not the new line 5 after skipping lines on retry). This could lead to using the wrong line error handling for the second retry
Contributor
Author
|
Example Logs: |
vakalapa
reviewed
Nov 3, 2022
| if err != nil { | ||
| metrics.SendErrorLogAndMetric(util.IpsmID, "error: failed to apply ipsets: %s", err.Error()) | ||
| // exponentially increase maxRestoreTryCount | ||
| iMgr.maxRestoreTryCount *= 2 |
Contributor
There was a problem hiding this comment.
Why do we want to exponentially increase here?
Contributor
There was a problem hiding this comment.
this just results in 10 tries, we can just remove this and change the largestretry to 10
Contributor
Author
There was a problem hiding this comment.
discussed offline. setting a constant limit of 5
matmerr
previously approved these changes
Nov 8, 2022
matmerr
dismissed
their stale review
let's reconsider the perf impacts of dumping all ipset lines
matmerr
approved these changes
Nov 22, 2022
rjdenney
pushed a commit
to rjdenney/azure-container-networking
that referenced
this pull request
Jan 19, 2023
) * adaptively modify linux max restore try count to prevent perpetual errors * remove debug print * log restore file and send ipsetmanager_linux errors * send other appropriate errors * fix handleLineError function * fix printing restore lines and enhance a log * fix lints and wrap chainLineNumber errors * fix one off error for logging the try count * revert exponential increase to try limit * update try count to 5 and update UTs * do not log lines for every restore call until perf is understood
smittal22
pushed a commit
to smittal22/azure-container-networking
that referenced
this pull request
Jan 26, 2023
) * adaptively modify linux max restore try count to prevent perpetual errors * remove debug print * log restore file and send ipsetmanager_linux errors * send other appropriate errors * fix handleLineError function * fix printing restore lines and enhance a log * fix lints and wrap chainLineNumber errors * fix one off error for logging the try count * revert exponential increase to try limit * update try count to 5 and update UTs * do not log lines for every restore call until perf is understood
smittal22
pushed a commit
to smittal22/azure-container-networking
that referenced
this pull request
Jan 30, 2023
) * adaptively modify linux max restore try count to prevent perpetual errors * remove debug print * log restore file and send ipsetmanager_linux errors * send other appropriate errors * fix handleLineError function * fix printing restore lines and enhance a log * fix lints and wrap chainLineNumber errors * fix one off error for logging the try count * revert exponential increase to try limit * update try count to 5 and update UTs * do not log lines for every restore call until perf is understood
smittal22
pushed a commit
to smittal22/azure-container-networking
that referenced
this pull request
Feb 3, 2023
) * adaptively modify linux max restore try count to prevent perpetual errors * remove debug print * log restore file and send ipsetmanager_linux errors * send other appropriate errors * fix handleLineError function * fix printing restore lines and enhance a log * fix lints and wrap chainLineNumber errors * fix one off error for logging the try count * revert exponential increase to try limit * update try count to 5 and update UTs * do not log lines for every restore call until perf is understood
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a cluster had 2+ persistent errors in dirty IPSets, then new changes may not get applied.
This PR also enhances logging:
print each line in the restore file(commented out until perf is understood)Fixes: