fix: [WIN-NPM] don't remove policy from cache when updating pod #1568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huntergregory
force-pushed
the
win-npm-remove-policy-fix
branch
from
f30987c to
280e232
Compare
vakalapa
reviewed
Sep 1, 2022
|
|
||
| // RemovePolicyForEndpoints is identical to RemovePolicy except it will not remove the policy from the cache. | ||
| // This function is intended for Windows only. | ||
| func (pMgr *PolicyManager) RemovePolicyForEndpoints(policyKey string, endpointList map[string]string) error { |
Contributor
There was a problem hiding this comment.
Where is this function being used ?
Contributor
Author
There was a problem hiding this comment.
forgot to commit. updated
huntergregory
force-pushed
the
win-npm-remove-policy-fix
branch
from
00605db to
9f41e4d
Compare
huntergregory
force-pushed
the
win-npm-remove-policy-fix
branch
from
f62654b to
4c821b1
Compare
vakalapa
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing a policy during updatePod(), the policy should not be removed from the cache. This would cause the policy to not be found when deleting the policy.
This PR also fixes the prometheus ACL metric for windows.