fix: [WIN-NPM] don't apply policy to new pod with same IP as an old pod #1569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huntergregory
force-pushed
the
win-npm-skip-adding-policy-to-stale-ip
branch
2 times, most recently
from
93ad337 to
f2b2249
Compare
huntergregory
force-pushed
the
win-npm-skip-adding-policy-to-stale-ip
branch
from
f2b2249 to
72672a6
Compare
ck319
previously approved these changes
Sep 13, 2022
matmerr
previously approved these changes
Sep 13, 2022
huntergregory
force-pushed
the
win-npm-skip-adding-policy-to-stale-ip
branch
from
72672a6 to
3e370f3
Compare
ck319
approved these changes
Nov 4, 2022
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
matmerr
approved these changes
Nov 8, 2022
vakalapa
approved these changes
Nov 10, 2022
rjdenney
pushed a commit
to rjdenney/azure-container-networking
that referenced
this pull request
Jan 19, 2023
…od (Azure#1569) * don't apply policy to IP's old pod owner * fix podkey/ip check * test case for pod key check * clarify error message * fix windows lint and have complete UT coverage of isIPAffiliated * comment out flaky UT for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting endpoints to apply a policy, ignore IPs that have a different pod key in the ipsetmanager versus the endpoint cache (in case the pod controller hasn't updated the dp yet that the IP's pod owner has changed).