Skip to content

Conversation

@tamilmani1989
Copy link
Member

@tamilmani1989 tamilmani1989 commented Sep 8, 2022

…ture

Reason for Change:

Issue Fixed:

This PR fixes azure-ipam support for aks swift overlay cluster. In AKS swift overlay mode, empty gatewayIP is getting passed from cns to azure-ipam and which is expected. Cilium/Azure CNI really doesn't use this gatewayip. So its better to skip parsing this gatewayIP and passing to Azure CNI

Requirements:

Notes:

Copy link
Collaborator

@rbtr rbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for my curiosity, would we use this in an AzCNIv1 scenario where we NAT traffic through the node?

@tamilmani1989
Copy link
Member Author

Cilium E2e pipeline

for my curiosity, would we use this in an AzCNIv1 scenario where we NAT traffic through the node?

nope not really. used only in bridge mode which we deprecated long ago

@tamilmani1989 tamilmani1989 merged commit 1f32c9f into master Sep 9, 2022
@tamilmani1989 tamilmani1989 deleted the tamanoha/azureipam_fix_overlay branch September 9, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants