fix: [NPM-Win] Get local endpoints for updatepod, but all endpoints for cleanup. #1606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
On 2 separate nodes, verified that we ignore all remote endpoints and do not ignore any local endpoints. Tested a cluster with 2 windows nodes and 1 master node. There were 2 customer Pods per windows node. 11 off-node kube-system Pods had corresponding HNS Endpoints. There were also 6 off-node kube-system Pods which didn't have remote HNS Endpoints. None of the customer Pods (on Windows nodes) had corresponding remote HNS Endpoints. The 11 ignored in this example: |
matmerr
approved these changes
Dec 12, 2022
rjdenney
pushed a commit
to rjdenney/azure-container-networking
that referenced
this pull request
Jan 19, 2023
…or cleanup. (Azure#1606) * fix: [NPM-WIN] Get only local endpoints to apply ACLs on * addding a const * fix lints * update UTs (TODO: uncomment multi-job test when fixed) * resolve lint again * true backwards compatibility * resolve TODO by uncommenting UT * fix lint Co-authored-by: Hunter Gregory <hunterlgregory@gmail.com>
smittal22
pushed a commit
to smittal22/azure-container-networking
that referenced
this pull request
Jan 26, 2023
…or cleanup. (Azure#1606) * fix: [NPM-WIN] Get only local endpoints to apply ACLs on * addding a const * fix lints * update UTs (TODO: uncomment multi-job test when fixed) * resolve lint again * true backwards compatibility * resolve TODO by uncommenting UT * fix lint Co-authored-by: Hunter Gregory <hunterlgregory@gmail.com>
smittal22
pushed a commit
to smittal22/azure-container-networking
that referenced
this pull request
Jan 30, 2023
…or cleanup. (Azure#1606) * fix: [NPM-WIN] Get only local endpoints to apply ACLs on * addding a const * fix lints * update UTs (TODO: uncomment multi-job test when fixed) * resolve lint again * true backwards compatibility * resolve TODO by uncommenting UT * fix lint Co-authored-by: Hunter Gregory <hunterlgregory@gmail.com>
smittal22
pushed a commit
to smittal22/azure-container-networking
that referenced
this pull request
Feb 3, 2023
…or cleanup. (Azure#1606) * fix: [NPM-WIN] Get only local endpoints to apply ACLs on * addding a const * fix lints * update UTs (TODO: uncomment multi-job test when fixed) * resolve lint again * true backwards compatibility * resolve TODO by uncommenting UT * fix lint Co-authored-by: Hunter Gregory <hunterlgregory@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Right now, GetEndpointsForNetwork gives all endpoint including remote endpoints which are not required. This is causing duplicate endpoints for the same IP.
This change will only take all endpoints while cleaning up (for backward compatibility) and will filter only local endpoints for all other purposes.
Issue Fixed:
Requirements:
Notes: