Add Cilium on AKS Overlay e2e scenario #1609
Merged
+341
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
reviewed
Sep 14, 2022
hack/swift/Makefile
Outdated
Comment on lines
98
to
99
| --network-plugin azure \ | ||
| --network-plugin-mode overlay \ |
Collaborator
There was a problem hiding this comment.
Does this work? I think we will end up with the AKS managed CNS and AzCNI on the nodes.
We were able to use prod AKS clusters for SWIFT because I made sure BYO CNI supported SWIFT from the back-end when a podsubnet was set ("no CNI but SWIFT-capable"). I don't think we have enabled a "no CNI but overlay-capable" mode.
@thatmattlong is BYO+Overlay on something you have considered? Will we need to build an AKS standalone to run Overlay E2Es in, again?
Member
|
Lets hold on to this PR until we have BYO cni overlay support |
Member
|
@camrynl Given @tamilmani1989 's comment above, please mark this as a draft until it's ready to merge. |
rbtr
previously approved these changes
Nov 2, 2022
rbtr
approved these changes
Nov 11, 2022
rjdenney
pushed a commit
to rjdenney/azure-container-networking
that referenced
this pull request
Jan 19, 2023
* add hack overlay make target and e2e templates * update pipeline.yaml with new overlay stage * use dropgz/overlay-byocni in acn pr and submodule pipeline * name overlay clusters for submodule pipeline * modify dropgz setup * test ipam + overlay * use azilium conflist * add overlay configmap * add deployment of ip-masq-agent to cluster * set flag in ip-masq-agent deployment * update deployment * configmap creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
-Adding new target to hack/swift/Makefile to build byocni overlay cluster.
-Creating e2e tests for Cilium on AKS Overlay
Issue Fixed:
Requirements:
Notes: