Skip to content

Conversation

@camrynl
Copy link
Contributor

@camrynl camrynl commented Sep 15, 2022

Reason for Change:

Adding cniTest.Dockerfile in order to test any changes to azure-ipam and azure-vnet as a part of dropgz.
Building and testing a separate cni-dropgz-test image for e2e validation. Keeping this separate from the existing cni-dropgz image, so that image can remain and be used when needed for release.

Issue Fixed:

Requirements:

Notes:

@camrynl camrynl requested a review from rbtr September 22, 2022 17:27
@tamilmani1989 tamilmani1989 changed the title adding cniTest.Dockerfile for e2e testing adding dropgz test dockerfile for e2e testing Sep 22, 2022
@rbtr
Copy link
Collaborator

rbtr commented Sep 24, 2022

pls don't update with merge, use rebase. merge adds all these extra commits that hide real changes 😢
the GH UI even lets you update with rebase:
image

rbtr
rbtr previously approved these changes Sep 24, 2022
Copy link
Collaborator

@rbtr rbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"approved with suggestions"

@camrynl camrynl requested a review from rbtr September 28, 2022 15:39
@camrynl camrynl enabled auto-merge (squash) September 28, 2022 15:40
@camrynl camrynl merged commit 40f8289 into Azure:master Sep 28, 2022
@camrynl camrynl deleted the testCniDockerfile branch September 28, 2022 17:21
rjdenney pushed a commit to rjdenney/azure-container-networking that referenced this pull request Jan 19, 2023
* add new dockerfile for testing cni-dropgz

* add make targets for cni-dropgz-test manifest

* modify versioning in cni-dropgz-test manifest

* platform versioning for test image

* fix build of test image

* update go version for dropgz

* building vnet-ipam and vnet-telemetry

* copy azure-vnet* to grab all vnet binaries

* modify build for vnet-ipam

* fix copying of cns conflist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants