Fix: Added a metric to monitor the subnet exhaustion state within the Ipam Monitor Pool #1620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nairashu
force-pushed
the
asn/IPExhaustMetrics
branch
from
c632360 to
178f535
Compare
Collaborator
|
@nairashu FYI, if you put |
neaggarwMS
reviewed
Sep 19, 2022
nairashu
force-pushed
the
asn/IPExhaustMetrics
branch
from
8f1fce0 to
f18a204
Compare
neaggarwMS
reviewed
Sep 20, 2022
rbtr
requested changes
Sep 20, 2022
rbtr
requested changes
Sep 21, 2022
…to a counter metric and fixed linting issues
…tches between subnet exhaustion and reversal for each subnet
rbtr
force-pushed
the
asn/IPExhaustMetrics
branch
from
0629492 to
b368ade
Compare
rbtr
approved these changes
Sep 27, 2022
rjdenney
pushed a commit
to rjdenney/azure-container-networking
that referenced
this pull request
Jan 19, 2023
… Ipam Monitor Pool (Azure#1620) * Added a metric to monitor the subnet exhaustion state within the Ipam Monitor Pool * Fixed the PR comments * Added a reconciler error metric * Addressed code review comments * Updating lint on code * Addressed all code review comments and changed the reconciler metric to a counter metric and fixed linting issues * Added a count metric for IPAM pool as well to count the number of switches between subnet exhaustion and reversal for each subnet * Updated the makefile to be able to run linting with better garbage collection * Updated the code with the PR review comments * Updated the label values based on a discussion offline with Evan Co-authored-by: asn <asn@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
Reason for Change:
The PR is for adding a metric to be able to identify if the IPAM Pool Monitor is able to read the subnet exhaustion state change and compare it with the Batch size metric to verify the batch changes match with this state change.
Issue Fixed:
Requirements:
Notes: