Skip to content

Conversation

@csfmomo
Copy link
Contributor

@csfmomo csfmomo commented Oct 13, 2022

Update aks-engine version for acn validation. New version is using the latest aks-engine release and remove duplicated and unnecessary npm tests. Remove unnecessary resource clean up step in pipeline since it's already included in the aks-e e2e test. Also update the Kubernetes version accordingly.
It can accelerate the pipeline validation for almost 1 hour.

https://dev.azure.com/msazure/One/_build/results?buildId=62165531&view=results
image

Reason for Change:

Issue Fixed:

Requirements:

Notes:

@csfmomo csfmomo changed the title [DRAFT]Separate the npm test and cni test, comment out npm test first. It's a Update the aks-e version for pipeline validation. Oct 18, 2022
@csfmomo csfmomo requested review from jaer-tsun and rbtr October 18, 2022 05:54
@rbtr rbtr requested a review from vakalapa October 18, 2022 16:18
estebancams
estebancams previously approved these changes Oct 18, 2022
@rbtr rbtr added npm Related to NPM. ci Infra or tooling. labels Oct 18, 2022
vakalapa
vakalapa previously approved these changes Oct 18, 2022
@vakalapa
Copy link
Contributor

AKS-E npm validation scenarios

  1. Applying a network policy to deny ingress access, then validate there is no ingress access anymore
  2. Applying a network policy to deny egress access, then validate there is no egress access anymore
  3. Applying a network policy to allow ingress to certain tag/label, then validate there is ingress access to that tag/label but no access to the pods that doesn't match
  4. Applying a network policy to allow egress to certain tag/label, then validate there is egress access to that tag/label but no access to the pods that doesn't match
  5. Applying a network policy to allow ingress to certain namespace, then validate there is ingress access to that namespace but no access to the pods namespace doesn't match

These tests are covered more extensively in cyclonus and conformance NPM pipelines

@csfmomo csfmomo enabled auto-merge (squash) October 18, 2022 22:01
@rbtr rbtr dismissed stale reviews from vakalapa and estebancams via c5e7163 October 18, 2022 22:24
rbtr
rbtr previously approved these changes Oct 18, 2022
test-kubernetes already did this work.
latest aks-engine release and remove duplicated and unnecessary npm
tests. Remove unnecessary resource clean up step in pipeline since it's
already included in the aks-e e2e test. Also update the kubnernetes version accordingly.
@csfmomo csfmomo merged commit 8970ab8 into master Oct 20, 2022
@csfmomo csfmomo deleted the aksepipeline branch October 20, 2022 16:29
rjdenney pushed a commit to rjdenney/azure-container-networking that referenced this pull request Jan 19, 2023
* Separate the npm test and cni test, comment out npm test first. It's a
testing PR.

* Revert unnecessary change.

* update aks-e version from v1.0.1 to v1.0.2

* Update cluster definition from version 1.22.7 to 1.22.15

* Update resource group name.

* Comment out unnecessary resource group deletion since the
test-kubernetes already did this work.

* Update aks-engine version for acn validation. New version is using the
latest aks-engine release and remove duplicated and unnecessary npm
tests. Remove unnecessary resource clean up step in pipeline since it's
already included in the aks-e e2e test. Also update the kubnernetes version accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Infra or tooling. npm Related to NPM.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants