Skip to content

[NPM][Windows] remove Windows22 preview flag and k8s version #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 18, 2022
Merged

[NPM][Windows] remove Windows22 preview flag and k8s version #1660

merged 4 commits into from
Oct 18, 2022
+0 −25

Conversation

@vakalapa
Copy link
Contributor

@vakalapa vakalapa commented Oct 18, 2022 •
edited by huntergregory
Loading

Reason for Change:

  • AKSWindows2022Preview flag is removed since Windows Server 22 is now GA'ed.
  • k8s version does not need to be specified and can prevent cluster from creating if the version goes out of service.

Issue Fixed:

Requirements:

Notes:

@vakalapa vakalapa requested a review from matmerr October 18, 2022 16:44
@huntergregory huntergregory changed the title [NPM][Windows] remove Windows22 preview flag [NPM][Windows] remove Windows22 preview flag and k8s version Oct 18, 2022
@huntergregory huntergregory added npm Related to NPM. ci Infra or tooling. labels Oct 18, 2022
@vakalapa vakalapa merged commit 062139e into master Oct 18, 2022
@vakalapa vakalapa deleted the vakr/removewin22flag branch October 18, 2022 20:10
rjdenney pushed a commit to rjdenney/azure-container-networking that referenced this pull request Jan 19, 2023
@vakalapa @huntergregory @rjdenney
[NPM][Windows] remove Windows22 preview flag and k8s version (Azure#1660
e1c6ebb 
)

* [NPM][Windows] remove preview flag

* remove k8s version in one file

* remove k8s version in another file

* remove k8s version in third file

Co-authored-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matmerr matmerr matmerr approved these changes

Assignees

No one assigned

Labels

ci Infra or tooling. npm Related to NPM.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vakalapa @matmerr @huntergregory