Skip to content

fix: correct supportedApis path #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 1, 2022
Merged

fix: correct supportedApis path #1682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
506aa84
fix: correct supportedApis path
ZetaoZhuang Oct 27, 2022
e641094
Merge branch 'master' into fix_supported_apis_path
ZetaoZhuang Oct 28, 2022
8990832
Merge branch 'master' into fix_supported_apis_path
ZetaoZhuang Oct 31, 2022
25f58c1
Merge branch 'master' into fix_supported_apis_path
ZetaoZhuang Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nmagent/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,14 +408,14 @@ func TestNMAgentSupportedAPIs(t *testing.T) {
{
"empty",
nil,
"/machine/plugins/?comp=nmagent&type=network/nmagentsupportedapis",
"/machine/plugins/?comp=nmagent&type=GetSupportedApis",
"<SupportedAPIsResponseXML></SupportedAPIsResponseXML>",
false,
},
{
"happy",
[]string{"foo"},
"/machine/plugins/?comp=nmagent&type=network/nmagentsupportedapis",
"/machine/plugins/?comp=nmagent&type=GetSupportedApis",
"<SupportedAPIsResponseXML><type>foo</type></SupportedAPIsResponseXML>",
false,
},
Expand Down
2 changes: 1 addition & 1 deletion nmagent/requests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ func (s *SupportedAPIsRequest) Method() string {

// Path returns the necessary URI path for invoking a supported APIs request.
func (s *SupportedAPIsRequest) Path() string {
return "/network/nmagentsupportedapis"
return "/GetSupportedApis"
}

// Validate is a no-op method because SupportedAPIsRequests have no parameters,
Expand Down