Skip to content

log: [NPM] warn instead of error on invalid Pod IPs #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vakalapa merged 1 commit into from
Dec 14, 2022
Merged

log: [NPM] warn instead of error on invalid Pod IPs #1718

vakalapa merged 1 commit into from
Dec 14, 2022

Conversation

@huntergregory
Copy link
Contributor

@huntergregory huntergregory commented Dec 12, 2022

Do not reque Pods with bad IPs, and reduce wording from "error" to "warn".

Previous Errors

Pod with IPv6

2022/07/28 19:39:21 [79064] [podController processNextWorkItem] Error: failed to syncPod netpol-779-y/a. Requeuing with err: failed to sync pod due to Operation [AddPod] failed with error code [999], full cmd [], full error [syncAddedPod] Error: ADD POD  [netpol-779-y/a/aksawin22000002/map[pod:a]/2001:0db8:85a3:0000:0000:8a2e:0370:7334] failed as the PodIP is not valid ipv4 address

Pod with no IP

2022/07/28 19:39:21 [79064] [podController processNextWorkItem] Error: failed to syncPod netpol-779-y/a. Requeuing with err: failed to sync pod due to Operation [AddPod] failed with error code [999], full cmd [], full error [syncAddedPod] Error: ADD POD  [netpol-779-y/a/aksawin22000002/map[pod:a]/] failed as the PodIP is not valid ipv4 address

@huntergregory huntergregory added the npm Related to NPM. label Dec 12, 2022
@huntergregory huntergregory requested a review from a team as a code owner December 12, 2022 23:22
@huntergregory huntergregory requested review from ck319 and removed request for a team December 12, 2022 23:22
@vakalapa vakalapa merged commit 1f1aacf into master Dec 14, 2022
@vakalapa vakalapa deleted the hgregory/ignore-bad-ip branch December 14, 2022 17:55
rjdenney pushed a commit to rjdenney/azure-container-networking that referenced this pull request Jan 19, 2023
@huntergregory @rjdenney
log: [NPM] warn instead of error on invalid Pod IPs (Azure#1718)
d7f02ac 
warn instead of error on invalid Pod IPs
smittal22 pushed a commit to smittal22/azure-container-networking that referenced this pull request Jan 26, 2023
@huntergregory @smittal22
log: [NPM] warn instead of error on invalid Pod IPs (Azure#1718)
0a1b91a 
warn instead of error on invalid Pod IPs
smittal22 pushed a commit to smittal22/azure-container-networking that referenced this pull request Jan 30, 2023
@huntergregory @smittal22
log: [NPM] warn instead of error on invalid Pod IPs (Azure#1718)
9e7dcd1 
warn instead of error on invalid Pod IPs
smittal22 pushed a commit to smittal22/azure-container-networking that referenced this pull request Feb 3, 2023
@huntergregory @smittal22
log: [NPM] warn instead of error on invalid Pod IPs (Azure#1718)
c368e6c 
warn instead of error on invalid Pod IPs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vakalapa vakalapa vakalapa approved these changes

@ck319 ck319 Awaiting requested review from ck319 ck319 is a code owner automatically assigned from Azure/acn-npm-reviewers

Assignees

No one assigned

Labels

npm Related to NPM.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huntergregory @vakalapa