refactor and move the nmagentConfig code from cns to namgent package. #1723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it can be reused in other components
ZetaoZhuang
requested review from
ashvindeodhar,
rbtr and
timraymond
and removed request for
a team
timraymond
approved these changes
Dec 15, 2022
ashvindeodhar
approved these changes
Jan 11, 2023
rjdenney
pushed a commit
to rjdenney/azure-container-networking
that referenced
this pull request
Jan 19, 2023
…Azure#1723) * refactor and move the nmagentConfig code from cns to namgent package.
smittal22
pushed a commit
to smittal22/azure-container-networking
that referenced
this pull request
Jan 26, 2023
…Azure#1723) * refactor and move the nmagentConfig code from cns to namgent package.
smittal22
pushed a commit
to smittal22/azure-container-networking
that referenced
this pull request
Feb 3, 2023
…Azure#1723) * refactor and move the nmagentConfig code from cns to namgent package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
refactor and move the nmagentConfig code from cns to namgent package. So it can be reused in other components (dnc...)
Issue Fixed:
Requirements:
Notes: