remove windows 2004 aks-e tests from pipeline #1736
Merged
+0
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebancams
changed the title
estebancams
force-pushed
the
estebanca/remove-windows-2004-stage-from-pipeline
branch
from
645ae36 to
243f805
Compare
pjohnst5
approved these changes
Jan 3, 2023
Contributor
pjohnst5
left a comment
pjohnst5
left a comment
There was a problem hiding this comment.
LGTM as long as it's not available in AKS anyways (and aks-e is deprecated now)
It does fail quite often so in my opinion it is best to remove it while we then put the win 22 tests in for aks
pjohnst5
previously requested changes
Jan 3, 2023
Contributor
pjohnst5
left a comment
pjohnst5
left a comment
There was a problem hiding this comment.
Yeah maybe we should first get win 22 operational before removing this based on discussion offline
rbtr
approved these changes
Jan 3, 2023
rbtr
dismissed
pjohnst5’s stale review
dismissing per further discussion, okay to merge and previously approved
rjdenney
pushed a commit
to rjdenney/azure-container-networking
that referenced
this pull request
Jan 19, 2023
* feat: remove windos 2004 aks-e tests from pipeline * fix: dependency on cleanup stage Co-authored-by: Esteban Capillo <estebancams@microsoft.com>
smittal22
pushed a commit
to smittal22/azure-container-networking
that referenced
this pull request
Jan 26, 2023
* feat: remove windos 2004 aks-e tests from pipeline * fix: dependency on cleanup stage Co-authored-by: Esteban Capillo <estebancams@microsoft.com>
smittal22
pushed a commit
to smittal22/azure-container-networking
that referenced
this pull request
Feb 3, 2023
* feat: remove windos 2004 aks-e tests from pipeline * fix: dependency on cleanup stage Co-authored-by: Esteban Capillo <estebancams@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
We still don't support windows 2004 for aks and aks-e tests are failing very often. While we determine the root cause, in order to allow PRs to go in, and since we'll still run windows 1903 tests, we can disable 2004 tests as a mitigation
A new task was reported to add win 22 tests once we migrate over from aks-e (https://msazure.visualstudio.com/One/_workitems/edit/16667635)
Issue Fixed:
Requirements:
Notes: