fix: [NPM-WIN] ignore irrelevant errors from ipsetmanager #1741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huntergregory
force-pushed
the
hgregory/issue-1613
branch
from
51cae74 to
45be656
Compare
huntergregory
changed the title
vakalapa
approved these changes
Jan 5, 2023
rjdenney
pushed a commit
to rjdenney/azure-container-networking
that referenced
this pull request
Jan 19, 2023
* ignore certain errors * remove changes to updatePod tracking (on/off-node)
smittal22
pushed a commit
to smittal22/azure-container-networking
that referenced
this pull request
Feb 3, 2023
* ignore certain errors * remove changes to updatePod tracking (on/off-node)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
deleteIPSetsAndReferences(), ignore the error that the set doesn't exist just in case this is possible.a. In
ApplyDataPlane(), ignore errors related to updating pods. These errors are retriable and should not block other dataplane operations.b. In
UpdatePod(), ignore sets to add/remove that don't exist anymore (i.e. they were deleted in the background ipset reconcile thread after all referenced Policies were deleted from the kernel)