nmagent get nv version list api V2 refactor #1744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
requested review from
rbtr and
timraymond
and removed request for
rsagasthya
timraymond
requested changes
Jan 10, 2023
…ing into v2Refactor
Collaborator
|
@csfmomo there are several linting issues on this branch still, can you fix those? You can check the lint locally with |
timraymond
previously requested changes
Jan 18, 2023
csfmomo
dismissed
timraymond’s stale review
I'll open another PR to address test error message format.
rbtr
approved these changes
Jan 19, 2023
smittal22
pushed a commit
to smittal22/azure-container-networking
that referenced
this pull request
Feb 3, 2023
* tmp commit for onbaording nma v2 * Remove test output file * Remove unnecessary code when CNS onboard get nc version list without token * tmp commit to fix getnc version tests when onboarding nc version api v2 from nmagent. * Fix the unit test for nmagent v2 api change. * Fix unit test TestGetNetworkContainerVersionStatus * Revert back to GetNCVersionF test. * Roll back to get nc version api v1 for test. * Continue revert back and store nc version url * Onboard nmagent get nc version api v2. * Address pr feedback of returning early and remove comment out code. * Remove unnecessary ncVersionURLs and NCVersionRequest. * Remove unnecessary variables. * Update nmagent get nc version api v2 to v2 url * Remove comment out code. * tmp commit for onbaording nma v2 * Remove test output file * Remove unnecessary code when CNS onboard get nc version list without token * tmp commit to fix getnc version tests when onboarding nc version api v2 from nmagent. * Fix the unit test for nmagent v2 api change. * Fix unit test TestGetNetworkContainerVersionStatus * Revert back to GetNCVersionF test. * Roll back to get nc version api v1 for test. * Continue revert back and store nc version url * Onboard nmagent get nc version api v2. * Address pr feedback of returning early and remove comment out code. * Remove unnecessary ncVersionURLs and NCVersionRequest. * Remove unnecessary variables. * Update nmagent get nc version api v2 to v2 url * Remove comment out code. * Update nmagent get nc version list. * Address feedback and fix golint * Fix lint issue. * Fix the remaining 2 lint issues. * Revert back test error generation to address feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Refactor the way we get nc version. CNS used to call nmagent nc version api v1 which needs auth token, today, nmagent provides v2 api which doesn't need token and the process can be simplified.
work item 14734259
Issue Fixed:
Requirements:
Notes: