-
Notifications
You must be signed in to change notification settings - Fork 260
feat: [NPM-WIN] support for CAPZ windows testing #1752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6480039 to
cdfa27a
Compare
cdfa27a to
149a0f9
Compare
9b56cff to
3df9d9f
Compare
3df9d9f to
7964a89
Compare
683864e to
33758c2
Compare
33758c2 to
de3b8f3
Compare
huntergregory
commented
Jan 27, 2023
This reverts commit e101482.
…zure-container-networking into hgregory/capz-kubeconfig
vakalapa
approved these changes
Mar 2, 2023
rjdenney
pushed a commit
that referenced
this pull request
Mar 13, 2023
* set kubeconfig on capz * update dockerfile * test network name Calico * add base acls * add WindowsNetworkName toggle and revert hard coded Calico parts * update base acls for calico and add UTs * capitalize calico network name * fix connectivity. try with host allow acls * revert change to policy_windows.go * more UTs and add base ACLs for other "new endpoint" scenario * run all UTs * update npm image to .42 * add log line * allow traffic going inter-node * Revert "allow traffic going inter-node" This reverts commit e101482. * add long-runner pod for testing vfp tags in capz * fix lints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to enable NPM on CAPZ Windows Testing for use in run-capz-e2e.sh. This setup uses Calico CNI.
Changes
1/3: kubeconfig Location
CAPZ stores the default kubeconfig in a different location, so we must have a different DaemonSet command to copy from this location.
Files:
2/3: Toggle for Windows Network Name
Can now configure "calico" HNS network (as well as the standard "azure").
3/3: Add Connectivity
Add Base ACLs to Endpoints
Without Calico NetPol, a Calico CNI Endpoint looks like:
We will add the below ACLs, which are all of the ACLs on Azure CNI Endpoints. Note we have to increase the priority on two of the ACLs (from 65500 to 65499).
We also need to include the following ACLs, which are a subset of ACLs seen on Endpoints where Calico CNI and NetPol are enabled. Without these ACLs, we get this error when trying to connect Pods:
dial tcp 192.168.240.198:80: connectex: An attempt was made to access a socket in a way forbidden by its access permissions..Note 1: to use existing NPM code, have to disregard the following fields in the original Calico ACLs: "Protocol", "LocalPort", "RemotePort", and "InternalPort".
Note 2: interestingly, the result in HNS for the above ACLs looks like the below. For instance, "RuleType" is not displayed. The above socket error does not occur though.
ACL Appendix
HNS Policies on an Azure CNI Endpoint
HNS Policies on a Calico CNI Endpoint (with NetPol enabled)