deprecate SetOwnerRef in favor of SetControllerRef #1801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
force-pushed
the
fix/crd-client-owner-method
branch
5 times, most recently
from
75e8268 to
769257d
Compare
rbtr
force-pushed
the
fix/crd-client-owner-method
branch
from
769257d to
00b3ef3
Compare
timraymond
previously approved these changes
Feb 22, 2023
rbtr
force-pushed
the
fix/crd-client-owner-method
branch
from
7e4f662 to
2960d1b
Compare
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Co-authored-by: Timothy J. Raymond <timraymond@users.noreply.github.com>
rbtr
force-pushed
the
fix/crd-client-owner-method
branch
from
2960d1b to
85f5339
Compare
timraymond
approved these changes
Feb 23, 2023
rjdenney
pushed a commit
that referenced
this pull request
Mar 13, 2023
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Evan Baker rbtr@users.noreply.github.com
The
SetOwnerRefmethod was misleadingly named - it actually callsctrlutil.SetControllerReferenceand patches, notctrlutil.SetOwnerReferencewhich also exists.This renames the method to
SetControllerRefso that it is named what it does. A deprecated stubSetOwnerRefwhich forwards to the new method is left for backwards compatibility.Reason for Change:
Issue Fixed:
Requirements:
Notes: