Skip to content

deprecate SetOwnerRef in favor of SetControllerRef #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2023
Merged

deprecate SetOwnerRef in favor of SetControllerRef #1801

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7d5e61
deprecate SetOwnerRef in favor of SetControllerRef
rbtr Feb 10, 2023
85f5339
fix copypasta
rbtr Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion crd/nodenetworkconfig/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,14 @@ func (c *Client) UpdateSpec(ctx context.Context, key types.NamespacedName, spec
return nnc, nil
}

// SetOwnerRef sets the owner of the NodeNetworkConfig to the given object, using HTTP Patch
// SetOwnerRef sets the controller of the NodeNetworkConfig to the given object atomically, using HTTP Patch.
// Deprecated: SetOwnerRef is deprecated, use the more correctly named SetControllerRef.
func (c *Client) SetOwnerRef(ctx context.Context, key types.NamespacedName, owner metav1.Object, fieldManager string) (*v1alpha.NodeNetworkConfig, error) {
return c.SetControllerRef(ctx, key, owner, fieldManager)
}

// SetControllerRef sets the controller of the NodeNetworkConfig to the given object atomically, using HTTP Patch.
func (c *Client) SetControllerRef(ctx context.Context, key types.NamespacedName, owner metav1.Object, fieldManager string) (*v1alpha.NodeNetworkConfig, error) {
obj := genPatchSkel(key)
if err := ctrlutil.SetControllerReference(owner, obj, Scheme); err != nil {
return nil, errors.Wrapf(err, "failed to set controller reference for nnc")
Expand Down