fix: [WIN-NPM] filter HNS endpoints #1848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huntergregory
force-pushed
the
hgregory/npm-filter-endpoints
branch
from
cd567fb to
f1f5d00
Compare
|
|
||
| // NOTE see assumptions of hnsv2wrapperfake.ListEndpointsQuery | ||
| func (h Hnsv2wrapperwithtimeout) ListEndpointsQuery(query hcn.HostComputeQuery) ([]hcn.HostComputeEndpoint, error) { | ||
| r := make(chan ListEndpointsFuncResult) |
Contributor
There was a problem hiding this comment.
this leaks goroutines when they try to send to the channel after the timeout has fired. fix is to make this a buffered chan of size 1.
Contributor
Author
Testing Non-Attached ContainerCreated non-Pod endpoint, and NPM did not see it: Testing Remote Endpoints
Verified that:
|
vakalapa
previously approved these changes
Mar 29, 2023
huntergregory
force-pushed
the
hgregory/npm-filter-endpoints
branch
2 times, most recently
from
4e75895 to
5042897
Compare
…ure/azure-container-networking into hgregory/npm-filter-endpoints
3 tasks
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
vakalapa
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Filter HNS endpoints for running, local Pods. This will improve endpoint cache management, preventing any race conditions.
Issue Fixed:
N/A
Requirements:
Notes: