Skip to content

fix: [WIN-NPM] back-compat mitigation to PATH issue #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 27, 2023
+0 −4
Merged

fix: [WIN-NPM] back-compat mitigation to PATH issue #1867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5120063
fix: [WIN-NPM] update PATH so we can use debugging tools via NPM
huntergregory Mar 21, 2023
1563283
append to path instead of overwriting
huntergregory Mar 22, 2023
9cf6611
set original path
huntergregory Mar 23, 2023
0ea4e9a
Update azure-npm-capz.yaml
huntergregory Mar 23, 2023
f295f23
add powershell to PATH in setkubeconfigpath.ps1
huntergregory Mar 23, 2023
891400e
Merge branch 'master' into hgregory/npm-path
huntergregory Mar 23, 2023
e672621
remove pwsh call and undo path updates and change to setkubeconfig.ps1
huntergregory Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion npm/examples/windows/azure-npm-capz.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ spec:
[
'.\setkubeconfigpath-capz.ps1',
";",
"powershell.exe",
'.\npm.exe',
"start",
'--kubeconfig=.\kubeconfig',
Expand Down
3 changes: 0 additions & 3 deletions npm/examples/windows/azure-npm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ spec:
[
'.\setkubeconfigpath.ps1',
";",
"powershell.exe",
'.\npm.exe',
"start",
'--kubeconfig=.\kubeconfig',
Expand All @@ -108,8 +107,6 @@ spec:
fieldPath: spec.nodeName
- name: NPM_CONFIG
value: .\\etc\\azure-npm\\azure-npm.json
- name: PATH
Copy link
Contributor Author

@huntergregory huntergregory Mar 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove our first attempt at mitigation, which is not back-compat and is incomplete (can't use vfpctrl and other tools used by HNS to collect logs)

value: '%CONTAINER_SANDBOX_MOUNT_POINT%\Windows\System32\WindowsPowershell\v1.0\'
volumeMounts:
- name: azure-npm-config
mountPath: .\\etc\\azure-npm
Expand Down