cilium ci: set l7proxy to false #1884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
increase golint timeout from 10 to 15m
rbtr
approved these changes
Apr 3, 2023
Collaborator
rbtr
left a comment
rbtr
left a comment
There was a problem hiding this comment.
lgtm but why does it have @huntergregory's change in the commit log?
Contributor
Author
not sure, it showed up after I clicked rebase on the pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
L7proxy has been disabled in AKS cilium config for GA. Setting L7Proxy to false for ACN pipeline testing.
Issue Fixed:
Requirements:
Notes: