Adding check to prevent duplicate Network Container creation #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exists and the version has not changed.
saiyan86
changed the title
saiyan86
suggested changes
Jul 6, 2018
| break | ||
|
|
||
| // create/update nc only if it doesn't exist or it exists and the requested version is different from the saved version | ||
| if !ok || (ok && existing.VMVersion != req.Version) { |
Contributor
There was a problem hiding this comment.
It'd be better to exit case early. Example:
if (ok && existing.VMVersion) = req.Version {
break
}
if err = nc.Create(req); err != nil {
.
.
.
}
| case "POST": | ||
| if req.NetworkContainerType == cns.WebApps { | ||
| // try to get the saved nc state if it exists | ||
| service.lock.Lock() |
jaer-tsun
force-pushed
the
check_nc_update_version
branch
from
bfa2f06 to
b51cdfa
Compare
jaer-tsun
force-pushed
the
check_nc_update_version
branch
from
b51cdfa to
66c7831
Compare
saiyan86
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adding check to prevent AzureNetworkContainer.exe from running if nc exists and the version has not changed.