Skip to content

Conversation

@paulyufan2
Copy link
Contributor

@paulyufan2 paulyufan2 commented Jun 5, 2023

Reason for Change:

We should have removed 3389 port from AKS Engine PR. Those were getting reported in S360 and are also part of exposed ports.

Issue Fixed:

Requirements:

https://github.com/csfmomo/aks-engine/releases/tag/v1.0.9.3

Notes:

@paulyufan2 paulyufan2 requested a review from a team as a code owner June 5, 2023 23:28
@paulyufan2 paulyufan2 requested review from aegal and pjohnst5 June 5, 2023 23:28
@paulyufan2 paulyufan2 changed the title [DO NOT REVIEW] remove udp port 3389 remove udp port 3389 Jun 6, 2023
Copy link
Contributor

@pjohnst5 pjohnst5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, given it passes the Azure Container Networking PR checks

@paulyufan2 paulyufan2 enabled auto-merge (squash) June 6, 2023 18:00
@paulyufan2 paulyufan2 disabled auto-merge June 6, 2023 18:00
@paulyufan2 paulyufan2 enabled auto-merge (squash) June 6, 2023 21:56
@paulyufan2 paulyufan2 force-pushed the 24184940 branch 2 times, most recently from 00ab1f1 to a162390 Compare June 7, 2023 01:03
@paulyufan2
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s), but failed to run 2 pipeline(s).

@paulyufan2
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s), but failed to run 2 pipeline(s).

@paulyufan2 paulyufan2 disabled auto-merge June 7, 2023 02:07
@paulyufan2 paulyufan2 enabled auto-merge (squash) June 7, 2023 02:10
@paulyufan2
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s), but failed to run 2 pipeline(s).

@paulyufan2 paulyufan2 disabled auto-merge June 7, 2023 02:24
@paulyufan2 paulyufan2 enabled auto-merge (squash) June 7, 2023 14:48
@paulyufan2 paulyufan2 merged commit 7743fda into master Jun 7, 2023
@paulyufan2 paulyufan2 deleted the 24184940 branch June 7, 2023 18:27
@tamilmani1989 tamilmani1989 added the ci Infra or tooling. label Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Infra or tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants