Skip to content

Conversation

@pjohnst5
Copy link
Contributor

@pjohnst5 pjohnst5 commented Jun 9, 2023

Add third 'overlay' option to CNS conflist generator
Will be used in AKS once #2008 is rolled out in AKS

@pjohnst5 pjohnst5 changed the title 'Overlay' conflist generator for CNS 'overlay' conflist generator for CNS Jun 9, 2023
@pjohnst5 pjohnst5 added cns Related to CNS. enhancement labels Jun 9, 2023
@pjohnst5 pjohnst5 marked this pull request as ready for review June 12, 2023 16:35
@pjohnst5 pjohnst5 requested review from a team as code owners June 12, 2023 16:35
@pjohnst5 pjohnst5 requested a review from ramiro-gamarra June 12, 2023 16:35
@pjohnst5
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@pjohnst5 pjohnst5 force-pushed the paujohns/cns-generate-overlay-option branch from 351d585 to 0b41a7f Compare June 12, 2023 17:46
@pjohnst5 pjohnst5 requested a review from rbtr June 12, 2023 18:17
@pjohnst5 pjohnst5 requested a review from thatmattlong June 12, 2023 18:26
Copy link
Collaborator

@rbtr rbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjohnst5 pjohnst5 enabled auto-merge (squash) June 12, 2023 20:09
@pjohnst5 pjohnst5 merged commit f687dee into Azure:master Jun 12, 2023
@pjohnst5 pjohnst5 deleted the paujohns/cns-generate-overlay-option branch June 12, 2023 21:18
@rbtr
Copy link
Collaborator

rbtr commented Jun 12, 2024

@pjohnst5 can you backport this change to 1.4? I know that 1.4 doesn't support dualstack, but it is still using the "v4overlay" key and I would like to be able to simplify the usage in AKS to only "overlay".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cns Related to CNS. enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants