-
Notifications
You must be signed in to change notification settings - Fork 260
Moving v4overlay and dualstackoverlay to just 'overlay' in CNI #2008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving v4overlay and dualstackoverlay to just 'overlay' in CNI #2008
Conversation
…nd adding 'overlay' in same 'if' checks as 'v4' and 'dualstack', also removing v4swift from overlay conflists (isnt used)
|
/cc @thatmattlong for awareness |
|
|
Tested this on a v4overlay cluster and pod to pod connectivity worked for both linux and windows |
rbtr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but I will defer to @tamilmani1989 to approve
tamilmani1989
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Here's the general idea:
---- This is where all AKS clusters, have the same conflist now (basically) ----
Final cleanup stage