Removing a network policy test that is unreliable #2017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjohnst5
force-pushed
the
paujohns/disable-aks-engine-network-policy-tests
branch
from
defe764 to
f58f7cd
Compare
pjohnst5
changed the title
pjohnst5
changed the title
tamilmani1989
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should disable these network policy tests, as they are flaky (confirmed), and we now have npm conformance tests which are better (and are scoped to NPM related changes, not blocking other PRs related to other components)
Here's a run that succeeded, and then a different run with the same code (for both ACN, and aks-engine), that failed:
Success:
<internal link, dm me for details>
Failed:
<internal link, dm me for details>
You may notice that on the failed run, we are now on attempt 4 to get it to work (cc Saksham Mittal) for a release
We are removing this flaky test from the aks-engine test suite, since it is logically incorrect, but has "succeded" in the past, therefore it is not reliable, and even if we "fix" it to be logically correct, it could just cause more problems in the future, and is blocking PRs / Releases
So we are removing it
Fix:
csfmomo/aks-engine#3
csfmomo/aks-engine#4
csfmomo/aks-engine#5
Release:
https://github.com/csfmomo/aks-engine/releases/tag/v1.0.9.5