fix: updating CNI version in dropgz to 1.5.4 #2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjohnst5
requested review from
ashvindeodhar,
camrynl,
paulyufan2,
rbtr and
thatmattlong
as code owners
rbtr
approved these changes
Jun 16, 2023
Contributor
Author
|
I deleted v0.0.8, both tag and release of dropgz I will figure out how to purge that image from mcr v0.0.9 of dropgz will have the fix |
Contributor
Author
|
v0.0.8 is purged |
…rlay' conflist option
pjohnst5
force-pushed
the
paujohns/update-cni-binary-dropgz
branch
from
08ac6bb to
7b2ded0
Compare
Contributor
Author
|
Incorporates #2008 (cniv1.5.4 change) into v0.0.9 dropgz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating CNI version in dropgz to CNI v1.5.4, so that the CNI conflist installed with dropgz doesn't break CNI (was using CNI binary 1.5.0 in dropgz, which doesn't support new 'overlay' CNI conflist option, breaking it)
Release dropgz/v0.0.8 is unusable/unstable, we should not share it with anyone, should I delete the release @rbtr ?
I did not realize I had to change this variable for dropgz to use a new CNI version, that is my bad
I tested this new change, with dropgz both installing the conflist, and installing the binary, pod creation worked, and connectivity was good:
new-dropgz-testing.zip