Returning IPAddress instead of IPPrefix in CNI ADD response #2038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamilmani1989
requested changes
Jun 30, 2023
tamilmani1989
requested changes
Jul 12, 2023
timraymond
reviewed
Jul 14, 2023
…working into ronak-31/return_ipaddress_cni_add
tamilmani1989
previously approved these changes
Jul 14, 2023
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
…working into ronak-31/return_ipaddress_cni_add
…m/ronak-31/azure-container-networking into ronak-31/return_ipaddress_cni_add
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s), but failed to run 1 pipeline(s). |
Member
|
e2e succeeded in retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
CNI ADD call is sending IPPrefix instead of IPAddress in the response.
For honeycomb container(baremetal containers) it is expected to send IPAddress.
For honeycomb container after container creation AtalsAgent creates a URL and executes http probe using it to check container's health. But ADD response is sending IPPrefix so the URL is getting formed incorrectly and the probe is failing.
For example, It will form this kind of url http://[260a:10b1:90f:ac12::]:6798/Data which will fail as it doesn't have exact IPAddress.
Issue Fixed:
Sending IPAddress instead of IPPrefix in ADD response to fix this.
Requirements:
Notes: