-
Notifications
You must be signed in to change notification settings - Fork 260
ci: use team build pool #2055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use team build pool #2055
Conversation
hack/aks/Makefile
Outdated
| REGION ?= westus2 | ||
| OS_SKU ?= Ubuntu | ||
| VM_SIZE ?= Standard_B2s | ||
| VM_SIZE ?= Standard_DS3_v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think the default vm or lb skus should be changed, these are way more expensive. if we need bigger nodes for say a load test, then that test should override this via the env var
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh I'm not opinionated about the changes in this pr, I'm just reusing the pipeline for quick clusters at the moment :)
| --load-balancer-sku standard \ | ||
| --network-plugin none \ | ||
| --network-plugin-mode overlay \ | ||
| --pod-cidr 192.168.0.0/16 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bunch of the overlay and cilium tests implicitly depend on this value being 192.168.0.0/16, why do we need to change it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
emphasis on the do-not-merge tag, I'm using this target for a convenient one-click byocni cilium overlay cluster for manual testing
I believe I can still use refs/pull/2055/merge as a target if pr is converted to draft
|
This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days |
|
Pull request closed due to inactivity. |
Reason for Change:
Faster than waiting in the massive pool
edit: using this pr for manual testing, do not merge, no intention to merge
Issue Fixed:
Requirements:
Notes: