Skip to content

Conversation

@matmerr
Copy link
Member

@matmerr matmerr commented Jul 12, 2023

Reason for Change:

Faster than waiting in the massive pool

edit: using this pr for manual testing, do not merge, no intention to merge

Issue Fixed:

Requirements:

Notes:

@matmerr matmerr requested a review from a team as a code owner July 12, 2023 20:15
@matmerr matmerr requested a review from jpayne3506 July 12, 2023 20:15
@matmerr matmerr changed the title use team pool ci: use team build pool Jul 12, 2023
@tamilmani1989 tamilmani1989 requested a review from vipul-21 July 12, 2023 20:30
rbtr
rbtr previously approved these changes Jul 12, 2023
@vipul-21
Copy link
Contributor

@matmerr I have this PR already open with the same changes: #2036
But i think because of the ACN pr pipeline it is not merged yet.

REGION ?= westus2
OS_SKU ?= Ubuntu
VM_SIZE ?= Standard_B2s
VM_SIZE ?= Standard_DS3_v2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think the default vm or lb skus should be changed, these are way more expensive. if we need bigger nodes for say a load test, then that test should override this via the env var

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh I'm not opinionated about the changes in this pr, I'm just reusing the pipeline for quick clusters at the moment :)

--load-balancer-sku standard \
--network-plugin none \
--network-plugin-mode overlay \
--pod-cidr 192.168.0.0/16 \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bunch of the overlay and cilium tests implicitly depend on this value being 192.168.0.0/16, why do we need to change it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emphasis on the do-not-merge tag, I'm using this target for a convenient one-click byocni cilium overlay cluster for manual testing

I believe I can still use refs/pull/2055/merge as a target if pr is converted to draft

@matmerr matmerr marked this pull request as draft July 26, 2023 16:47
@github-actions
Copy link

github-actions bot commented Nov 7, 2023

This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Nov 7, 2023
@github-actions
Copy link

Pull request closed due to inactivity.

@github-actions github-actions bot closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge stale Stale due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants