Removing addition of default routes before HNS network creation #2059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
When ipv6 is enabled, if the
azureHNS network is not present, CNI adds some default routes tovEthernet (Ethernet 2)before creating the network. On subsequent invocations, CNI recognizes that the network exists, and does not try to add the routes again.If the
vEthernet (Ethernet 2)interface is not present for some extraneous reason, adding default routes will continue to fail and thus theazurenetwork never gets created, thus making CNI never succeed for any containers.This PR removes addition of these routes since they are just an optimization, and always letting CNI create the azure network.