ci: Skip cilium encryption tests #2377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamilmani1989
approved these changes
Nov 10, 2023
vipul-21
approved these changes
Nov 10, 2023
| - script: | | ||
| kubectl delete ns load-test | ||
| cilium connectivity test --connect-timeout 4s --request-timeout 30s | ||
| cilium connectivity test --connect-timeout 4s --request-timeout 30s --test '!pod-to-pod-encryption,!node-to-node-encryption' |
Contributor
There was a problem hiding this comment.
Can we add a comment specifying from which cli version this is added from.
And what cilium agent it supports. We need to keep a track of it once we are on higher versions of cilium i guess.
Contributor
Author
There was a problem hiding this comment.
I can add a comment Enable these tests when encryption feature is enabled , but the reason why the tests were originally disabled was because we have encryption disabled. Upstream Cilium CLI update changed it to where only if the cluster is a single node cluster do these tests not run. IMO as long as we have encryption disabled we should not run these tests and explicitly defining it as such will ensure future changes to this test do not impact us.
jpayne3506
changed the title
jpayne3506
force-pushed
the
jpayne3506/connectivityskip
branch
from
c22410a to
a9c6e50
Compare
jpayne3506
force-pushed
the
jpayne3506/connectivityskip
branch
from
a9c6e50 to
a3c28cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Update to Cilium CLI brought in tests that we do not functionally need or use.
Issue Fixed:
Requirements:
Notes: