Skip to content

update stale workflow #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2023
Merged

update stale workflow #2439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/stale.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ jobs:
stale:
runs-on: ubuntu-latest
permissions:
contents: write
issues: write
pull-requests: write
steps:
Expand All @@ -17,11 +18,12 @@ jobs:
ascending: true
close-issue-message: 'Issue closed due to inactivity.'
close-pr-message: 'Pull request closed due to inactivity.'
days-before-close: 14
days-before-stale: 60
exempt-issue-labels: 'blocked,must,should,keep'
days-before-close: 7
days-before-stale: 14
delete-branch: true
Copy link
Contributor

@ramiro-gamarra ramiro-gamarra Dec 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the new workflow uses branches from this repo instead of forks, not sure if we want to delete the branch. With forking I always have a remote with my branch, but now all my branches are going to be here and I may not always have a local to push again. Let me know if am misunderstanding this line.

Copy link
Collaborator Author

@rbtr rbtr Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your understanding is correct. This was not previously enabled because it couldn't delete forked branches anyway.
I think deleting the branch if a PR is closed for being stale is appropriate. It will be 3 weeks of total inactivity - after 2 weeks, the stale label is added, and anyone can remove that to preserve the PR. There's definitely the potential to lose a branch, but there needs to be motivation to not abandon PRs.

Copy link
Contributor

@ramiro-gamarra ramiro-gamarra Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are stale branches that much of an issue? I definitely agree with closing PRs to eliminate noise, but they can always be reactivated.

Copy link
Collaborator Author

@rbtr rbtr Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could similarly argue that the official Org repo should be for actively contributing and collaborating and stale branches are also noise and don't belong there. It's straightforward enough to re-push a branch from your local, or to work primarily in a fork and only push to the upstream remote when you're ready to actually open the PR and follow through all the way to merging it.

Copy link
Contributor

@ramiro-gamarra ramiro-gamarra Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that even if branches are deleted, there is a restore option in the PR as well (although not sure how long that remains available after delete). Even if the branch cannot be restored, commits should still be discoverable via the closed PRs, so work won't be totally lost, which is my main concern. I think I'm ok to try this change and see if we have any issues in the next few months. It seems you will still need to add one more permission for this to work though: https://github.com/actions/stale?tab=readme-ov-file#delete-branch

Copy link
Collaborator Author

@rbtr rbtr Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added contents: write

exempt-issue-labels: 'exempt-stale'
operations-per-run: 100
stale-issue-message: 'This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days'
stale-pr-message: 'This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days'
stale-issue-message: 'This issue is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days'
stale-pr-message: 'This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days'
- name: Print outputs
run: echo ${{ join(steps.stale.outputs.*, ',') }}