Skip to content

Conversation

@PatrickLang
Copy link
Contributor

What this PR does / why we need it:

If you run ./build/build-all.sh or ./build/build-all-containerized.sh, it will fail:

command-line-arguments
go build -v -o output/_/cni/azure-vnet-ipam.exe -ldflags "-X main.version=v1.0.12-rc3-8-g009ebee-dirty -s -w" cni/ipam/plugin/*.go
github.com/Azure/azure-container-networking/cni/ipam
command-line-arguments
cp cni/azure-.conflist output/_/cni/10-azure.conflist
cp: cannot stat 'cni/azure-.conflist': No such file or directory
Makefile:246: recipe for target 'cni-archive' failed
make: *** [cni-archive] Error 1
Makefile:169: recipe for target 'all-containerized' failed
make: *** [all-containerized] Error 2

This fixes it and will show proper usage instead.

@PatrickLang
Copy link
Contributor Author

@jhowardmsft here's what I was stuck on trying to build CNI

Copy link
Member

@matmerr matmerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this PR got lost to the ages! We're not using this script in any CI or prod scenarios, so I think that's why it went unnoticed

@matmerr matmerr merged commit bb1871a into Azure:master Jun 25, 2020
pjohnst5 referenced this pull request in pjohnst5/azure-container-networking Jul 9, 2020
Co-authored-by: Patrick Lang <plang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants