Skip to content

Conversation

@jpayne3506
Copy link
Contributor

Reason for Change:

Calls for package kubernetes - WaitForPodDaemonset() would result in a race condition if an update command was used to restart the Daemonset. This resulted in make test-load having a built in race condition every time TestValidCNSStateDuringScaleAndCNSRestartToTriggerDropgzInstall() test was called.

To ensure that functionality is gained, RestartCNSDaemonset() has a new flag waitForReady that then calls WaitForPodDaemonset() to ensure that all pods within the daemonset are ready and updated to the newest revision.

Issue Fixed:

Requirements:

Notes:

@jpayne3506 jpayne3506 added the ci Infra or tooling. label Jan 8, 2024
@jpayne3506 jpayne3506 self-assigned this Jan 8, 2024
@jpayne3506 jpayne3506 requested a review from a team as a code owner January 8, 2024 20:30
@jpayne3506 jpayne3506 requested a review from vipul-21 January 8, 2024 20:30
@jpayne3506 jpayne3506 changed the title ci; Improve package kubernetes and load ci: Improve package kubernetes and load Jan 8, 2024
@rbtr rbtr enabled auto-merge January 9, 2024 16:28
@rbtr
Copy link
Collaborator

rbtr commented Jan 9, 2024

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rbtr rbtr added this pull request to the merge queue Jan 9, 2024
Merged via the queue into master with commit 430db14 Jan 9, 2024
@rbtr rbtr deleted the jpayne3506/k8scns branch January 9, 2024 20:17
matmerr pushed a commit that referenced this pull request Jan 17, 2024
* ci: add waitForReady to RestartCNS

* ci: improve CNS restart

* chore: Lint fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Infra or tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants