Skip to content

ci: Replace make test-intergration within ACN PR pipeline [1/2] #2463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 27, 2024
Merged

ci: Replace make test-intergration within ACN PR pipeline [1/2] #2463

merged 2 commits into from
Jan 27, 2024

Conversation

@jpayne3506
Copy link
Contributor

@jpayne3506 jpayne3506 commented Dec 29, 2023 •
edited
Loading

Reason for Change:

Replacing make test-integration with make test-load to unify the testing being done on CNIv2 E2E. In doing this goldpinger test are being removed from the PR pipeline with the goal of using them within the CNI Release Test Pipeline.

Issue Fixed:

Requirements:

Notes:

@jpayne3506 jpayne3506 added enhancement ci Infra or tooling. labels Dec 29, 2023
@jpayne3506 jpayne3506 self-assigned this Dec 29, 2023
@jpayne3506 jpayne3506 requested a review from a team as a code owner December 29, 2023 22:16
@jpayne3506 jpayne3506 requested a review from rjdenney December 29, 2023 22:16
pjohnst5
pjohnst5 previously approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@pjohnst5 pjohnst5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's GOO! 🚀

@jpayne3506 jpayne3506 force-pushed the jpayne3506/testload branch 3 times, most recently from 0b73b9a to 382350d Compare January 2, 2024 18:08
@jpayne3506
Copy link
Contributor Author

jpayne3506 commented Jan 8, 2024 •
edited
Loading

Breaking this PR into multiple PRs due to increased velocity from merge queue

@jpayne3506
Copy link
Contributor Author

jpayne3506 commented Jan 9, 2024

Once #2484 and #2485 merge, this PR will be rebased and ready for review.

@jpayne3506 jpayne3506 force-pushed the jpayne3506/testload branch 2 times, most recently from fa4034c to da25905 Compare January 17, 2024 00:52
@jpayne3506 jpayne3506 force-pushed the jpayne3506/testload branch 2 times, most recently from 3d0876f to acf83b7 Compare January 26, 2024 01:13
vipul-21
vipul-21 approved these changes Jan 26, 2024
View reviewed changes
pjohnst5
pjohnst5 approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@pjohnst5 pjohnst5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work John!

@jpayne3506 jpayne3506 enabled auto-merge January 26, 2024 19:37
@jpayne3506 jpayne3506 added this pull request to the merge queue Jan 26, 2024
Merged via the queue into master with commit d2f142f Jan 27, 2024
@jpayne3506 jpayne3506 deleted the jpayne3506/testload branch January 27, 2024 03:23
@jpayne3506 jpayne3506 changed the title ci: Replace make test-intergration within ACN PR pipeline ci: Replace make test-intergration within ACN PR pipeline [1/2] Jan 27, 2024
@jpayne3506 jpayne3506 mentioned this pull request Jan 27, 2024
Merged
4 tasks
@jpayne3506 jpayne3506 mentioned this pull request Jan 30, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vipul-21 vipul-21 vipul-21 approved these changes

@pjohnst5 pjohnst5 pjohnst5 approved these changes

@rjdenney rjdenney Awaiting requested review from rjdenney rjdenney is a code owner automatically assigned from Azure/azure-sdn-members

Assignees

@jpayne3506 jpayne3506

Labels

ci Infra or tooling.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jpayne3506 @vipul-21 @pjohnst5