Skip to content

ci: add OS scale timeout #2490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2024
Merged

ci: add OS scale timeout #2490

merged 1 commit into from
Jan 12, 2024

Conversation

@jpayne3506
Copy link
Contributor

@jpayne3506 jpayne3506 commented Jan 9, 2024

Reason for Change:

Set a standard time for TestLoad() per iteration for each OS type. Setting arbitrary to a default 30 limited the amount of iterations and did not take into account the performance differences between OS.

Issue Fixed:

Requirements:

Notes:

@jpayne3506 jpayne3506 requested a review from a team as a code owner January 9, 2024 23:09
@jpayne3506 jpayne3506 requested a review from alam-tahmid January 9, 2024 23:09
@jpayne3506 jpayne3506 added the ci Infra or tooling. label Jan 9, 2024
@jpayne3506 jpayne3506 self-assigned this Jan 9, 2024
@jpayne3506 jpayne3506 mentioned this pull request Jan 9, 2024
Merged
4 tasks
@jpayne3506 jpayne3506 enabled auto-merge January 10, 2024 23:43
vipul-21
vipul-21 reviewed Jan 11, 2024
View reviewed changes
test/integration/load/load_test.go
}

// This map is used exclusively for TestLoad. Windows is expected to take 10-15 minutes per iteration.
// Will change this as scale testing results are verified. This will ensure we keep a standard performance metric.
Copy link
Contributor

@vipul-21 vipul-21 Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this we will verify after merging or before ?

Copy link
Contributor Author

@jpayne3506 jpayne3506 Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After, as an ongoing process. Currently the only performance metric that I know of is for windows clusters and timed accordingly. Have not tested for linux or cilium specifically.

Copy link
Contributor

@vipul-21 vipul-21 Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be good to keep an eye on this to verify the changes.

@jpayne3506 jpayne3506 added this pull request to the merge queue Jan 12, 2024
Merged via the queue into master with commit ee0ff71 Jan 12, 2024
@jpayne3506 jpayne3506 deleted the jpayne3506/scaleTimeout branch January 12, 2024 22:25
paulyufan2 pushed a commit that referenced this pull request Jan 15, 2024
@jpayne3506 @paulyufan2
ci: add OS scale timeout (#2490)
d1409bb
MikeZappa87 added a commit that referenced this pull request Jan 16, 2024
@MikeZappa87
ci: setup cilium+hubble nightly run
a37866c 
deps: bump github.com/spf13/viper from 1.16.0 to 1.18.2 (#2495)

Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.16.0 to 1.18.2.
- [Release notes](https://github.com/spf13/viper/releases)
- [Commits](spf13/viper@v1.16.0...v1.18.2)

---
updated-dependencies:
- dependency-name: github.com/spf13/viper
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

change config to be uniform

ci: increase dependabot PR limit to 10 (#2497)

ci: constrain cilium to linux on Release Test Pipeline (#2489)

ci: constrain cilium to linux

ci: Improve CNI|NPM integration test (#2498)

* ci: increase timeout for CNI|NPM intergration test

* add: retry to generate NPM logs

deps: bump golang.org/x/sys from 0.15.0 to 0.16.0 (#2500)

Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.15.0 to 0.16.0.
- [Commits](golang/sys@v0.15.0...v0.16.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

deps: bump github.com/prometheus/client_golang from 1.16.0 to 1.18.0 (#2501)

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.16.0 to 1.18.0.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.16.0...v1.18.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

deps: bump google.golang.org/protobuf from 1.31.0 to 1.32.0 (#2502)

Bumps google.golang.org/protobuf from 1.31.0 to 1.32.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

deps: bump golang.org/x/crypto from 0.17.0 to 0.18.0 (#2492)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.17.0 to 0.18.0.
- [Commits](golang/crypto@v0.17.0...v0.18.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

deps: bump k8s.io/klog/v2 from 2.110.1 to 2.120.0 (#2503)

Bumps [k8s.io/klog/v2](https://github.com/kubernetes/klog) from 2.110.1 to 2.120.0.
- [Release notes](https://github.com/kubernetes/klog/releases)
- [Changelog](https://github.com/kubernetes/klog/blob/main/RELEASE.md)
- [Commits](kubernetes/klog@v2.110.1...v2.120.0)

---
updated-dependencies:
- dependency-name: k8s.io/klog/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

ci: verbose output for make test-load  (#2481)

ci: make test-load verbose output

fix review comments

deps: bump google.golang.org/grpc from 1.59.0 to 1.60.1 (#2494)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.59.0 to 1.60.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.59.0...v1.60.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

ci: add OS scale timeout (#2490)

ci: add kubeproxy restart before windows k8s conformance testing (#2496)

* ci: ensure kubeproxy is running on windows

* ci: add set -e

Signed-off-by: John Payne <89417863+jpayne3506@users.noreply.github.com>

---------

Signed-off-by: John Payne <89417863+jpayne3506@users.noreply.github.com>

ci: Improve TestValidateState calls from load package (#2484)

* ci: improve TestValidateState

* chore: address comments

fix: joining multiple dns server lists (#2506)

* fix: joining multiple dns server lists

* address comments

* add 0 check

fix: downgrade k8s components to 1.28 (#2505)

Signed-off-by: GitHub <noreply@github.com>
MikeZappa87 added a commit that referenced this pull request Jan 16, 2024
@MikeZappa87
ci: setup cilium+hubble nightly run
25b36c5 
deps: bump github.com/spf13/viper from 1.16.0 to 1.18.2 (#2495)

Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.16.0 to 1.18.2.
- [Release notes](https://github.com/spf13/viper/releases)
- [Commits](spf13/viper@v1.16.0...v1.18.2)

---
updated-dependencies:
- dependency-name: github.com/spf13/viper
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

change config to be uniform

ci: increase dependabot PR limit to 10 (#2497)

ci: constrain cilium to linux on Release Test Pipeline (#2489)

ci: constrain cilium to linux

ci: Improve CNI|NPM integration test (#2498)

* ci: increase timeout for CNI|NPM intergration test

* add: retry to generate NPM logs

deps: bump golang.org/x/sys from 0.15.0 to 0.16.0 (#2500)

Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.15.0 to 0.16.0.
- [Commits](golang/sys@v0.15.0...v0.16.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

deps: bump github.com/prometheus/client_golang from 1.16.0 to 1.18.0 (#2501)

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.16.0 to 1.18.0.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.16.0...v1.18.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

deps: bump google.golang.org/protobuf from 1.31.0 to 1.32.0 (#2502)

Bumps google.golang.org/protobuf from 1.31.0 to 1.32.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

deps: bump golang.org/x/crypto from 0.17.0 to 0.18.0 (#2492)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.17.0 to 0.18.0.
- [Commits](golang/crypto@v0.17.0...v0.18.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

deps: bump k8s.io/klog/v2 from 2.110.1 to 2.120.0 (#2503)

Bumps [k8s.io/klog/v2](https://github.com/kubernetes/klog) from 2.110.1 to 2.120.0.
- [Release notes](https://github.com/kubernetes/klog/releases)
- [Changelog](https://github.com/kubernetes/klog/blob/main/RELEASE.md)
- [Commits](kubernetes/klog@v2.110.1...v2.120.0)

---
updated-dependencies:
- dependency-name: k8s.io/klog/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

ci: verbose output for make test-load  (#2481)

ci: make test-load verbose output

fix review comments

deps: bump google.golang.org/grpc from 1.59.0 to 1.60.1 (#2494)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.59.0 to 1.60.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.59.0...v1.60.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

ci: add OS scale timeout (#2490)

ci: add kubeproxy restart before windows k8s conformance testing (#2496)

* ci: ensure kubeproxy is running on windows

* ci: add set -e

Signed-off-by: John Payne <89417863+jpayne3506@users.noreply.github.com>

---------

Signed-off-by: John Payne <89417863+jpayne3506@users.noreply.github.com>

ci: Improve TestValidateState calls from load package (#2484)

* ci: improve TestValidateState

* chore: address comments

fix: joining multiple dns server lists (#2506)

* fix: joining multiple dns server lists

* address comments

* add 0 check

fix: downgrade k8s components to 1.28 (#2505)

Signed-off-by: GitHub <noreply@github.com>
matmerr pushed a commit that referenced this pull request Jan 17, 2024
@jpayne3506 @matmerr
ci: add OS scale timeout (#2490)
6f5a2f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vipul-21 vipul-21 vipul-21 approved these changes

@camrynl camrynl camrynl approved these changes

@alam-tahmid alam-tahmid Awaiting requested review from alam-tahmid alam-tahmid is a code owner automatically assigned from Azure/azure-sdn-members

Assignees

@jpayne3506 jpayne3506

Labels

ci Infra or tooling.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jpayne3506 @vipul-21 @camrynl