ci: add kubeproxy restart before windows k8s conformance testing #2496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
vipul-21
reviewed
Jan 11, 2024
| displayName: "Setup Environment" | ||
| - ${{ if contains(parameters.os, 'windows') }}: | ||
| - script: | |
Contributor
There was a problem hiding this comment.
Should we add set -e incase it fails on any restart cmd ?
Signed-off-by: John Payne <89417863+jpayne3506@users.noreply.github.com>
vipul-21
approved these changes
Jan 12, 2024
paulyufan2
pushed a commit
that referenced
this pull request
Jan 15, 2024
* ci: ensure kubeproxy is running on windows * ci: add set -e Signed-off-by: John Payne <89417863+jpayne3506@users.noreply.github.com> --------- Signed-off-by: John Payne <89417863+jpayne3506@users.noreply.github.com>
MikeZappa87
added a commit
that referenced
this pull request
Jan 16, 2024
deps: bump github.com/spf13/viper from 1.16.0 to 1.18.2 (#2495) Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.16.0 to 1.18.2. - [Release notes](https://github.com/spf13/viper/releases) - [Commits](spf13/viper@v1.16.0...v1.18.2) --- updated-dependencies: - dependency-name: github.com/spf13/viper dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> change config to be uniform ci: increase dependabot PR limit to 10 (#2497) ci: constrain cilium to linux on Release Test Pipeline (#2489) ci: constrain cilium to linux ci: Improve CNI|NPM integration test (#2498) * ci: increase timeout for CNI|NPM intergration test * add: retry to generate NPM logs deps: bump golang.org/x/sys from 0.15.0 to 0.16.0 (#2500) Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.15.0 to 0.16.0. - [Commits](golang/sys@v0.15.0...v0.16.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> deps: bump github.com/prometheus/client_golang from 1.16.0 to 1.18.0 (#2501) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.16.0 to 1.18.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.16.0...v1.18.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> deps: bump google.golang.org/protobuf from 1.31.0 to 1.32.0 (#2502) Bumps google.golang.org/protobuf from 1.31.0 to 1.32.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> deps: bump golang.org/x/crypto from 0.17.0 to 0.18.0 (#2492) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.17.0 to 0.18.0. - [Commits](golang/crypto@v0.17.0...v0.18.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> deps: bump k8s.io/klog/v2 from 2.110.1 to 2.120.0 (#2503) Bumps [k8s.io/klog/v2](https://github.com/kubernetes/klog) from 2.110.1 to 2.120.0. - [Release notes](https://github.com/kubernetes/klog/releases) - [Changelog](https://github.com/kubernetes/klog/blob/main/RELEASE.md) - [Commits](kubernetes/klog@v2.110.1...v2.120.0) --- updated-dependencies: - dependency-name: k8s.io/klog/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> ci: verbose output for make test-load (#2481) ci: make test-load verbose output fix review comments deps: bump google.golang.org/grpc from 1.59.0 to 1.60.1 (#2494) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.59.0 to 1.60.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.59.0...v1.60.1) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> ci: add OS scale timeout (#2490) ci: add kubeproxy restart before windows k8s conformance testing (#2496) * ci: ensure kubeproxy is running on windows * ci: add set -e Signed-off-by: John Payne <89417863+jpayne3506@users.noreply.github.com> --------- Signed-off-by: John Payne <89417863+jpayne3506@users.noreply.github.com> ci: Improve TestValidateState calls from load package (#2484) * ci: improve TestValidateState * chore: address comments fix: joining multiple dns server lists (#2506) * fix: joining multiple dns server lists * address comments * add 0 check fix: downgrade k8s components to 1.28 (#2505) Signed-off-by: GitHub <noreply@github.com>
MikeZappa87
added a commit
that referenced
this pull request
Jan 16, 2024
deps: bump github.com/spf13/viper from 1.16.0 to 1.18.2 (#2495) Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.16.0 to 1.18.2. - [Release notes](https://github.com/spf13/viper/releases) - [Commits](spf13/viper@v1.16.0...v1.18.2) --- updated-dependencies: - dependency-name: github.com/spf13/viper dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> change config to be uniform ci: increase dependabot PR limit to 10 (#2497) ci: constrain cilium to linux on Release Test Pipeline (#2489) ci: constrain cilium to linux ci: Improve CNI|NPM integration test (#2498) * ci: increase timeout for CNI|NPM intergration test * add: retry to generate NPM logs deps: bump golang.org/x/sys from 0.15.0 to 0.16.0 (#2500) Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.15.0 to 0.16.0. - [Commits](golang/sys@v0.15.0...v0.16.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> deps: bump github.com/prometheus/client_golang from 1.16.0 to 1.18.0 (#2501) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.16.0 to 1.18.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.16.0...v1.18.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> deps: bump google.golang.org/protobuf from 1.31.0 to 1.32.0 (#2502) Bumps google.golang.org/protobuf from 1.31.0 to 1.32.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> deps: bump golang.org/x/crypto from 0.17.0 to 0.18.0 (#2492) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.17.0 to 0.18.0. - [Commits](golang/crypto@v0.17.0...v0.18.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> deps: bump k8s.io/klog/v2 from 2.110.1 to 2.120.0 (#2503) Bumps [k8s.io/klog/v2](https://github.com/kubernetes/klog) from 2.110.1 to 2.120.0. - [Release notes](https://github.com/kubernetes/klog/releases) - [Changelog](https://github.com/kubernetes/klog/blob/main/RELEASE.md) - [Commits](kubernetes/klog@v2.110.1...v2.120.0) --- updated-dependencies: - dependency-name: k8s.io/klog/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> ci: verbose output for make test-load (#2481) ci: make test-load verbose output fix review comments deps: bump google.golang.org/grpc from 1.59.0 to 1.60.1 (#2494) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.59.0 to 1.60.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.59.0...v1.60.1) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> ci: add OS scale timeout (#2490) ci: add kubeproxy restart before windows k8s conformance testing (#2496) * ci: ensure kubeproxy is running on windows * ci: add set -e Signed-off-by: John Payne <89417863+jpayne3506@users.noreply.github.com> --------- Signed-off-by: John Payne <89417863+jpayne3506@users.noreply.github.com> ci: Improve TestValidateState calls from load package (#2484) * ci: improve TestValidateState * chore: address comments fix: joining multiple dns server lists (#2506) * fix: joining multiple dns server lists * address comments * add 0 check fix: downgrade k8s components to 1.28 (#2505) Signed-off-by: GitHub <noreply@github.com>
matmerr
pushed a commit
that referenced
this pull request
Jan 17, 2024
* ci: ensure kubeproxy is running on windows * ci: add set -e Signed-off-by: John Payne <89417863+jpayne3506@users.noreply.github.com> --------- Signed-off-by: John Payne <89417863+jpayne3506@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Windows byocni clusters have kubeproxy turned off by default. Ensuring that kubeproxy is restarted before k8s conformance testing occurs ensures that edge cases do not impact windows testing.
Issue Fixed:
Requirements:
Notes: