Close telemetry socket when its done #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. fix for closing connection socket if server receives error on read
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
==========================================
+ Coverage 45.26% 45.79% +0.53%
==========================================
Files 25 25
Lines 3155 3177 +22
==========================================
+ Hits 1428 1455 +27
+ Misses 1504 1498 -6
- Partials 223 224 +1
Continue to review full report at Codecov.
|
jaer-tsun
reviewed
Feb 27, 2019
telemetry/telemetrybuffer.go
Outdated
|
|
||
| // Cancel - signal to tear down telemetry buffer | ||
| func (tb *TelemetryBuffer) Cancel() { | ||
| telemetryLogger.Printf("Calling cancel") |
jaer-tsun
reviewed
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: