Added UT in telemetry code to fix code coverage #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
==========================================
+ Coverage 46.32% 46.51% +0.19%
==========================================
Files 25 25
Lines 3424 3440 +16
==========================================
+ Hits 1586 1600 +14
- Misses 1598 1600 +2
Partials 240 240
Continue to review full report at Codecov.
|
jaer-tsun
reviewed
Mar 8, 2019
| telemetryLogger.Printf("Server closing client connection2") | ||
| conn.Close() | ||
| tb.connections = remove(tb.connections, index) | ||
| return |
Member
Author
There was a problem hiding this comment.
that is the right way..we should not remove array elements in iteration loop..also in one of the instances its crashed
ninzavivek
previously approved these changes
Mar 8, 2019
ninzavivek
previously approved these changes
Mar 9, 2019
vyvekaggarwal
approved these changes
Mar 12, 2019
ninzavivek
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #This PR fixes code coverage issue seen by #296 . The PR contains UT for server side closing connection first instead of client.
Special notes for your reviewer:
Release note: