Skip to content

Conversation

@matmerr
Copy link
Member

@matmerr matmerr commented Mar 15, 2019

What this PR does / why we need it:
Replace CircleCI with Azure Pipelines

Special notes for your reviewer:
Azure Pipelines bot also required: https://github.com/marketplace/azure-pipelines

Release note:

NONE

@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #314 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   46.48%   46.48%           
=======================================
  Files          25       25           
  Lines        3418     3418           
=======================================
  Hits         1589     1589           
  Misses       1581     1581           
  Partials      248      248

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83945fd...cd13345. Read the comment docs.

jaer-tsun
jaer-tsun previously approved these changes Mar 15, 2019
Copy link
Contributor

@jaer-tsun jaer-tsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just remove one of the commented lines (restserver test)

@matmerr
Copy link
Member Author

matmerr commented Mar 15, 2019

@jaer-tsun sounds good

@sharmasushant If possible, we can switch to Azure Pipelines instead of CircleCI, we just need the app to be installed:
https://github.com/marketplace/azure-pipelines

I have a sample pr with pipelines enabled on my fork:
matmerr#8

@saiyan86
Copy link
Contributor

saiyan86 commented Mar 19, 2019

@matmerr Remember to fill in the PR template...

@saiyan86
Copy link
Contributor

saiyan86 commented Mar 19, 2019

/lgtm. But we still need to wait for @sharmasushant's input

@matmerr matmerr requested a review from saiyan86 May 7, 2019 23:07
Copy link
Contributor

@saiyan86 saiyan86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saiyan86
Copy link
Contributor

Waiting for @sharmasushant's input

@matmerr matmerr changed the base branch from master to azure-pipelines September 12, 2019 23:58
@matmerr matmerr merged commit 8a515b2 into Azure:azure-pipelines Sep 13, 2019
@saiyan86
Copy link
Contributor

yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants