Skip to content

Conversation

@tamilmani1989
Copy link
Member

…/networkmonitor

  1. Added telemetry config through which we can configure reportTohost interval
  2. Added unit tests for changes

What this PR does / why we need it:

  1. This PR adds support for telemetry service to read config file which provides a way to configure time interval for sending telemetry payload to host
  2. Moved telemetry specific functions to telemetry package so that other components can use
  3. Start telemetry process with argument which indicates config directory ( eg: azure-vnet-telemetry -d <dir_path>). By default it will look for config in /opt/cni/bin.
  4. Moved log initialization in telemetry service process code.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
Run unit tests for linux and windows. Did sanity testing in linux and windows. For multitenancy, requires changes in cns/dnc which will be a separate PR

Release note:

…/networkmonitor

2. Added telemetry config through which we can configure reportTohost interval
3. Added unit tests for changes
@tamilmani1989 tamilmani1989 requested a review from jaer-tsun March 21, 2019 22:37
@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #317 into master will increase coverage by 0.8%.
The diff coverage is 64.1%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #317     +/-   ##
=========================================
+ Coverage   45.71%   46.51%   +0.8%     
=========================================
  Files          25       25             
  Lines        3478     3433     -45     
=========================================
+ Hits         1590     1597      +7     
+ Misses       1634     1587     -47     
+ Partials      254      249      -5
Impacted Files Coverage Δ
telemetry/telemetry.go 29.41% <0%> (ø) ⬆️
telemetry/telemetrybuffer.go 57.37% <65.78%> (-0.69%) ⬇️
npm/pod.go 62.62% <0%> (+0.77%) ⬆️
npm/namespace.go 59.43% <0%> (+0.78%) ⬆️
npm/nwpolicy.go 56.09% <0%> (+1.09%) ⬆️
npm/iptm/iptm.go 56.33% <0%> (+1.45%) ⬆️
telemetry/telemetrybuffer_linux.go 87.5% <0%> (+6.25%) ⬆️
npm/npm.go 10.28% <0%> (+8.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97d3ddc...60688d4. Read the comment docs.

Copy link
Contributor

@jaer-tsun jaer-tsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tamilmani1989 tamilmani1989 merged commit a11d510 into Azure:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants