fix: Updating the AvailabilityZone field in the NNC to be an int value as the return from NMA is an int value #3331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
previously approved these changes
Jan 7, 2025
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
added 3 commits
January 7, 2025 14:08
… as the return from NMA is an int value
…C has NCGoalstate as uint
nairashu
force-pushed
the
asn/NNCUpdate
branch
from
2ebc4f1 to
1b7885c
Compare
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rbtr
approved these changes
Jan 7, 2025
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
…e as the return from NMA is an int value (#3331) * fix: Updating the AvailabilityZone field in the NNC to be a int value as the return from NMA is an int value * fix: Updated the maifest as well * Keeping the version as uint to avoid casting it multiple times and DNC has NCGoalstate as uint --------- Co-authored-by: Ashish Nair <ashish.nair@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
fix: Updating the AvailabilityZone field in the NNC to be an int value as the return from NMA is an int value
Issue Fixed:
N/A
Requirements:
Notes: