Skip to content

fix: Updating the AvailabilityZone field in the NNC to be an int value as the return from NMA is an int value #3331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 8, 2025
Merged

fix: Updating the AvailabilityZone field in the NNC to be an int value as the return from NMA is an int value #3331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14c8d91
fix: Updating the AvailabilityZone field in the NNC to be a int value…
Jan 7, 2025
bfb7ee0
fix: Updated the maifest as well
Jan 7, 2025
1b7885c
Keeping the version as uint to avoid casting it multiple times and DN…
Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crd/nodenetworkconfig/api/v1alpha/nodenetworkconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ type NodeNetworkConfigSpec struct {
IPsNotInUse []string `json:"ipsNotInUse,omitempty"`
// AvailabilityZone contains the Azure availability zone for the virtual machine where network containers are placed.
// +kubebuilder:validation:Optional
AvailabilityZone string `json:"availabilityZone,omitempty"`
AvailabilityZone uint `json:"availabilityZone,omitempty"`
}

// Status indicates the NNC reconcile status
Expand Down
2 changes: 1 addition & 1 deletion crd/nodenetworkconfig/manifests/acn.azure.com_nodenetworkconfigs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ spec:
availabilityZone:
description: AvailabilityZone contains the Azure availability zone
for the virtual machine where network containers are placed.
type: string
type: integer
ipsNotInUse:
items:
type: string
Expand Down
Loading