Fix for CNI lock timedout issue. #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamilmani1989
requested review from
ashvindeodhar,
jaer-tsun,
ninzavivek and
saiyan86
Codecov Report
@@ Coverage Diff @@
## master #382 +/- ##
=======================================
Coverage 40.17% 40.17%
=======================================
Files 25 25
Lines 3547 3547
=======================================
Hits 1425 1425
Misses 1920 1920
Partials 202 202Continue to review full report at Codecov.
|
ashvindeodhar
requested changes
Jul 30, 2019
ashvindeodhar
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #This PR fixes CNI locktimeout issue in linux. If there are multiple cni calls at same time, then all process will try to start telemetry process and eventually endup in undesirable state( cni plugin hangs at telemetry write and lock not released). For this, moved starting telemetry service inside lock code. Fix for #372
Also moved log setup out of newplugin function to main code.
Special notes for your reviewer:
Release note: